[PATCH] D83926: [ValueTracking] Let isGuaranteedNotToBeUndefOrPoison use Operator, look into more ops

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 17 09:16:33 PDT 2020


jdoerfert added a comment.

Only one nit from my side, don't wait for me.



================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4835
+  if (auto *Opr = dyn_cast<Operator>(V)) {
+    if (canCreateUndef(Opr, true))
+      return false;
----------------
Nit: Can we have a comment `/* something */ true` so I know what true means ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83926/new/

https://reviews.llvm.org/D83926





More information about the llvm-commits mailing list