[PATCH] D84030: AMDGPU/GlobalISel: Select s16->s64 G_FPEXT

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstructions.td:857-860
 def : GCNPat <
   (f64 (fpextend f16:$src)),
-  (V_CVT_F64_F32_e32 (V_CVT_F32_F16_e32 $src))
+  (V_CVT_F64_F32_e32 (V_CVT_F32_F16_e32 VSrc_b32:$src))
 >;
----------------
arsenm wrote:
> I think having this as an instruction pattern was a hack; it would be better to handle this like the other casts with a split in the legalizer
This doesn't handle source modifiers for example


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84030/new/

https://reviews.llvm.org/D84030