[PATCH] D83990: [test-release] fallback to py3's venv module
Brian Cain via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 17 07:28:43 PDT 2020
bcain marked an inline comment as done.
bcain added inline comments.
================
Comment at: llvm/utils/release/test-release.sh:309
+venv=virtualenv
+if ! type -P 'virtualenv' > /dev/null 2>&1 ; then
----------------
hans wrote:
> Should this be inside an if [ $do_test_suite = "yes" ]; ?
>
> I think virtualenv is only used for test_suite.
> Should this be inside an if [ $do_test_suite = "yes" ]; ?
>
> I think virtualenv is only used for test_suite.
Yes, that seems right. I will change it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83990/new/
https://reviews.llvm.org/D83990
More information about the llvm-commits
mailing list