[PATCH] D83686: [NFCI] LoopSink pass requires PGO, so rename it as PGOLoopSink

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 17 05:06:07 PDT 2020


lebedev.ri added a comment.

In D83686#2158010 <https://reviews.llvm.org/D83686#2158010>, @mkazantsev wrote:

> Not sure why it is necessary to rename it in the first place, but looks fine.


I've talked with @fhahn in IRC yesterday about all the pieces of the puzzle i'm seeing,
and right now i'm no longer very sure if it really should be renamed, or i should to refactor it to

1. make it possible to disable cost model
2. also allow sinking from header (w/o costmodel)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83686/new/

https://reviews.llvm.org/D83686





More information about the llvm-commits mailing list