[PATCH] D83862: [AMDGPU] Add missing test prefixes

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 17 05:00:46 PDT 2020


foad marked an inline comment as done.
foad added a comment.

I've committed the easy bits as 2dc3d1b3136522e7c8e92d742d8ecc3405b9b4bb <https://reviews.llvm.org/rG2dc3d1b3136522e7c8e92d742d8ecc3405b9b4bb>.



================
Comment at: llvm/test/CodeGen/AMDGPU/perfhint.ll:33
 ; GCN-LABEL: {{^}}test_large_stride:
-; MemoryBound: 0
-; WaveLimiterHint : 1
+; GCN: MemoryBound: 0
+; GCN: WaveLimiterHint : 1
----------------
rampitec wrote:
> foad wrote:
> > This check fails.
> This one is memory bound, there are practically only memory operations here. I think it needs some ALU in between to catch large stride only as intended.
OK, fixed in f05bce86af32d7b5cf1ab28b3abf6ee473bf3ef1.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83862/new/

https://reviews.llvm.org/D83862





More information about the llvm-commits mailing list