foad added a comment. The generated code looks much better, thanks. The implementation looks OK to me too, but perhaps wait to see if @arsenm has comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84010/new/ https://reviews.llvm.org/D84010