[PATCH] D84016: [SVE][CodeGen] Add simple integer add tests for SVE tuple types

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 17 03:59:42 PDT 2020


david-arm created this revision.
david-arm added reviewers: sdesmalen, fpetrogalli, efriedma.
Herald added subscribers: llvm-commits, steven.zhang, psnobl, hiraditya, kristof.beyls, tschuett.
Herald added a reviewer: rengolin.
Herald added a project: LLVM.

I have added tests to:

  CodeGen/AArch64/sve-intrinsics-int-arith.ll

for doing simple integer add operations on tuple types. Since these
tests introduced new warnings due to incorrect use of
getVectorNumElements() I have also fixed up these warnings in the
same patch. These fixes are:

1. In DAGCombiner::visitCONCAT_VECTORS I have replaced a call to

getVectorNumElements with getVectorMinNumElements since the code
path works for both fixed and scalable vectors.

2. In narrowExtractedVectorBinOp I have changed the code to bail out

early for scalable vector types, since we've not yet hit a case that
proves the optimisations are profitable for scalable vectors.

3. In DAGTypeLegalizer::WidenVecRes_CONCAT_VECTORS I have replaced

calls to getVectorNumElements with getVectorMinNumElements in cases
that work with scalable vectors. For the other cases I have added
asserts that the vector is not scalable because we should not be
using shuffle vectors and build vectors in such cases.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D84016

Files:
  llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
  llvm/test/CodeGen/AArch64/sve-intrinsics-int-arith.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84016.278715.patch
Type: text/x-patch
Size: 6626 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200717/41ea7656/attachment.bin>


More information about the llvm-commits mailing list