[PATCH] D84003: [InstCombine] Fix replace select with Phis when branch has the same labels

Fri Jul 17 02:34:07 PDT 2020

hans added a comment.

In D84003#2157530 <https://reviews.llvm.org/D84003#2157530>, @lebedev.ri wrote:

> In D84003#2157524 <https://reviews.llvm.org/D84003#2157524>, @mkazantsev wrote:
>
> > Please add unit test.
>
>
> Until then, can we please revert to green?

Which one? D83284 <https://reviews.llvm.org/D83284>?

I think in general, reverting to green and then re-landing with a fix and test case is preferable to rushing a fix in like this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84003/new/

https://reviews.llvm.org/D84003