[PATCH] D83871: [llvm-readobj/readelf] - Refactor how the code dumps relocations.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In D83871#2157649 <https://reviews.llvm.org/D83871#2157649>, @jhenderson wrote:

> In D83871#2157573 <https://reviews.llvm.org/D83871#2157573>, @MaskRay wrote:
>
> > LLD uses `template RelTy` so there is prior art... For llvm-readobj, this seems to fix a misnomer. This is a +1 to me.
> >
> > Have you considered https://bugs.llvm.org/show_bug.cgi?id=44257 Does this change make that easier or more difficult to fix?
>
>
> +1 from me in principle. I actually think this will make that fix easier thanks to the overloaded `getAddend` function now existing.


Yeah, I'd say the it should make the fix slightly easier probably. Definitely should not be more difficult.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83871/new/

https://reviews.llvm.org/D83871