[PATCH] D83624: [DWARFYAML] Implement the .debug_rnglists section.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Thanks, LGTM in its current form.

In D83624#2157408 <https://reviews.llvm.org/D83624#2157408>, @Higuoxing wrote:

> Address comments & Make the debug_rnglists entry optional & Add test case (r).
>
> I haven't got an exact answer about segment selctor in the range list entry from the Dwarf-Discuss list (http://lists.dwarfstd.org/pipermail/dwarf-discuss-dwarfstd.org/2020-July/004646.html). But we're almost there, let's wait a little more time :-)


That's quite an impressive discussion you managed to kick off there! I've read through it and there seem to be two possible outcomes: 1) A segment-selector-sized field should precede every address, representing the segment selection or 2) if the spec doesn't explicitly mention the segment selector, ignore the field (it will still be in the header, but have no effect). I'd be inclined to implement 2), at least for now, but can always switch to 1) in the future, if the decision falls that way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83624/new/

https://reviews.llvm.org/D83624