[llvm] 3e0ccf9 - [ARM] halfword store hits llvm_unreachable with big-endian

[Simon Wallis via llvm-commits]

Author: Simon Wallis
Date: 2020-07-17T08:56:44+01:00
New Revision: 3e0ccf9a9075a3c6eb1d6cb750c77eb71167c2e4

URL: https://github.com/llvm/llvm-project/commit/3e0ccf9a9075a3c6eb1d6cb750c77eb71167c2e4
DIFF: https://github.com/llvm/llvm-project/commit/3e0ccf9a9075a3c6eb1d6cb750c77eb71167c2e4.diff

LOG: [ARM] halfword store hits llvm_unreachable with big-endian

Summary:
[ARM] halfword store hits llvm_unreachable with big-endian

Provide missing case in getFixupKindContainerSizeBytes().

This stops execution reaching llvm_unreachable("Unknown fixup kind!")

D83947

Reviewers: olista01, ostannard

Reviewed By: ostannard

Subscribers: ostannard, kristof.beyls, hiraditya, danielkiss, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D83947

Change-Id: I598aa1fb51fd1c6f424c557c85d6df6d1958bc62

Added: 
    llvm/test/CodeGen/ARM/store_half.ll

Modified: 
    llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp b/llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp
index 9ad595c016c4..b02aef3c338b 100644
--- a/llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp
+++ b/llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp
@@ -1010,6 +1010,7 @@ static unsigned getFixupKindContainerSizeBytes(unsigned Kind) {
   case ARM::fixup_t2_condbranch:
   case ARM::fixup_t2_uncondbranch:
   case ARM::fixup_t2_pcrel_10:
+  case ARM::fixup_t2_pcrel_9:
   case ARM::fixup_t2_adr_pcrel_12:
   case ARM::fixup_arm_thumb_bl:
   case ARM::fixup_arm_thumb_blx:

diff  --git a/llvm/test/CodeGen/ARM/store_half.ll b/llvm/test/CodeGen/ARM/store_half.ll
new file mode 100644
index 000000000000..c182f9c3f766
--- /dev/null
+++ b/llvm/test/CodeGen/ARM/store_half.ll
@@ -0,0 +1,9 @@
+; RUN: llc < %s -mtriple=thumbebv8.2a-arm-none-eabi -mattr=+fullfp16 -filetype=obj -o /dev/null
+; RUN: llc < %s -mtriple=thumbv8.2a-arm-none-eabi -mattr=+fullfp16 -filetype=obj -o /dev/null
+; RUN: llc < %s -mtriple=armebv8.2a-arm-none-eabi -mattr=+fullfp16 -filetype=obj -o /dev/null
+; RUN: llc < %s -mtriple=armv8.2a-arm-none-eabi -mattr=+fullfp16 -filetype=obj -o /dev/null
+
+define void @woah(half* %waythere) {
+  store half 0xHE110, half* %waythere
+  ret void
+}