[PATCH] D83834: Add test utility 'extract'

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Sorry, I should have paid more attention when doing my previous review.



================
Comment at: llvm/test/tools/extract/basic.s:2
+# REQUIRES: x86-registered-target
+# RUN: extract aa %s | llvm-mc -triple=x86_64 - 2>&1 | \
+# RUN:   FileCheck %s --check-prefix=AA --implicit-check-not='warning: bb'
----------------
Do you actually need to use llvm-mc at all? It seems a bit heavy duty. You could just use `FileCheck` directly on the output of `extract`, e.g.

```
# RUN: extract aa %s | FileCheck %s --check-prefix=AA --implicit-check-not=bb
...

# AA: {{^}}aa{{$}}

#--- aa
aa
```

I suppose that doesn't cover the line numbering, but perhaps that should be a different test?


================
Comment at: llvm/tools/extract/extract.cpp:26
+
+static cl::OptionCategory cat("extract Options");
+
----------------
MaskRay wrote:
> jhenderson wrote:
> > Is there a way of telling clang-tidy to allow a different naming style?
> Added `.clang-tidy` (like lldb/.clang-tidy and lld/.clang-tidy)
I'm not seeing the `.clang-tidy` in the file list?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83834/new/

https://reviews.llvm.org/D83834