[PATCH] D84003: [InstCombine] Fix replace select with Phis when branch has the same labels

Thu Jul 16 23:36:07 PDT 2020

lebedev.ri added a comment.

In D84003#2157536 <https://reviews.llvm.org/D84003#2157536>, @mkazantsev wrote:

> In D84003#2157530 <https://reviews.llvm.org/D84003#2157530>, @lebedev.ri wrote:
>
> > In D84003#2157524 <https://reviews.llvm.org/D84003#2157524>, @mkazantsev wrote:
> >
> > > Please add unit test.
> >
> >
> > Until then, can we please revert to green?
>
>
> Can we check in this fix and merge the test later? The bug here is pretty obvious. WDYT?

SGTM
The test is going to be ugly and fragile since it will need to outsmart worklist.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84003/new/

https://reviews.llvm.org/D84003