[PATCH] D83569: [PowerPC] Fix the killed flag in mi-peephole pass

[Zhang Kang via Phabricator via llvm-commits]

ZhangKang marked an inline comment as done.
ZhangKang added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:1562
+    SrcMI->getOperand(1).setIsKill(false);
+  }
+
----------------
shchenz wrote:
> Should we also consider `SrcMI->getOperand(0)` or legacy `MI.getOperand(1)`  at least when MI and and SrcMI are in same BB?
> 
> We have a API `fixupIsDeadOrKill` for kill/dead flag fixup.
The `SrcMI` will be removed if it's necessary in the line 1571. 

The `fixupIsDeadOrkill` is used for non-ssa, but the pass is a SSA pass. So, we can't using it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83569/new/

https://reviews.llvm.org/D83569