[compiler-rt] 947bf0f - [compiler-rt][NFC] Add missing 'override's
Logan Smith via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 16 20:12:32 PDT 2020
Author: Logan Smith
Date: 2020-07-16T20:07:57-07:00
New Revision: 947bf0fdf6e6445ce09ec85da956d4c5e7f467f8
URL: https://github.com/llvm/llvm-project/commit/947bf0fdf6e6445ce09ec85da956d4c5e7f467f8
DIFF: https://github.com/llvm/llvm-project/commit/947bf0fdf6e6445ce09ec85da956d4c5e7f467f8.diff
LOG: [compiler-rt][NFC] Add missing 'override's
Added:
Modified:
compiler-rt/lib/sanitizer_common/sanitizer_flags.cpp
compiler-rt/lib/sanitizer_common/sanitizer_stoptheworld_mac.cpp
Removed:
################################################################################
diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_flags.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_flags.cpp
index 684ee1e0b999..d3290493fd6d 100644
--- a/compiler-rt/lib/sanitizer_common/sanitizer_flags.cpp
+++ b/compiler-rt/lib/sanitizer_common/sanitizer_flags.cpp
@@ -91,7 +91,7 @@ class FlagHandlerInclude : public FlagHandlerBase {
}
return parser_->ParseFile(value, ignore_missing_);
}
- bool Format(char *buffer, uptr size) {
+ bool Format(char *buffer, uptr size) override {
// Note `original_path_` isn't actually what's parsed due to `%`
// substitutions. Printing the substituted path would require holding onto
// mmap'ed memory.
diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_stoptheworld_mac.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_stoptheworld_mac.cpp
index 6c577426ad56..7f9529aa3556 100644
--- a/compiler-rt/lib/sanitizer_common/sanitizer_stoptheworld_mac.cpp
+++ b/compiler-rt/lib/sanitizer_common/sanitizer_stoptheworld_mac.cpp
@@ -31,15 +31,15 @@ class SuspendedThreadsListMac : public SuspendedThreadsList {
public:
SuspendedThreadsListMac() : threads_(1024) {}
- tid_t GetThreadID(uptr index) const;
+ tid_t GetThreadID(uptr index) const override;
thread_t GetThread(uptr index) const;
- uptr ThreadCount() const;
+ uptr ThreadCount() const override;
bool ContainsThread(thread_t thread) const;
void Append(thread_t thread);
PtraceRegistersStatus GetRegistersAndSP(uptr index, uptr *buffer,
- uptr *sp) const;
- uptr RegisterCount() const;
+ uptr *sp) const override;
+ uptr RegisterCount() const override;
private:
InternalMmapVector<SuspendedThreadInfo> threads_;
More information about the llvm-commits
mailing list