[PATCH] D83247: [compiler-rt][asan][hwasan] Refactor shadow setup into sanitizer_common (NFCI)

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

In D83247#2157022 <https://reviews.llvm.org/D83247#2157022>, @tejohnson wrote:

> In D83247#2156967 <https://reviews.llvm.org/D83247#2156967>, @tejohnson wrote:
>
> > In D83247#2156950 <https://reviews.llvm.org/D83247#2156950>, @aeubanks wrote:
> >
> > > Hi, I think this is breaking our Android bots: https://crbug.com/1106482
> > >
> > > FAILED: lib/hwasan/CMakeFiles/RTHwasan.aarch64.dir/hwasan_dynamic_shadow.cpp.o 
> > >  /b/s/w/ir/cache/builder/src/third_party/llvm-build/Release+Asserts/bin/clang++  -DHWASAN_WITH_INTERCEPTORS=1 -I/b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/hwasan/.. --target=aarch64-linux-android21 --sysroot=/b/s/w/ir/cache/builder/src/third_party/android_ndk/toolchains/llvm/prebuilt/linux-x86_64/sysroot --gcc-toolchain=/b/s/w/ir/cache/builder/src/third_party/android_ndk/toolchains/llvm/prebuilt/linux-x86_64 -Wall -std=c++14 -Wno-unused-parameter -O3 -DNDEBUG    -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fno-stack-protector -fno-sanitize=safe-stack -fvisibility=hidden -fno-lto -O3 -gline-tables-only -Wno-gnu -Wno-variadic-macros -Wno-c99-extensions -Wno-non-virtual-dtor -fno-rtti -fPIC -ffreestanding -MD -MT lib/hwasan/CMakeFiles/RTHwasan.aarch64.dir/hwasan_dynamic_shadow.cpp.o -MF lib/hwasan/CMakeFiles/RTHwasan.aarch64.dir/hwasan_dynamic_shadow.cpp.o.d -o lib/hwasan/CMakeFiles/RTHwasan.aarch64.dir/hwasan_dynamic_shadow.cpp.o -c /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/hwasan/hwasan_dynamic_shadow.cpp
> > >  /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/hwasan/hwasan_dynamic_shadow.cpp:63:3: error: use of undeclared identifier 'UnmapFromTo'
> > >
> > >   UnmapFromTo(shadow_start + shadow_size, shadow_start + premap_shadow_size);
> >
> >
> > Looking...
>
>
> Have a simple fix, just testing it now.


I just committed a fix at c489ae2a8605761d784171ff7152dfc75ab7c064 <https://reviews.llvm.org/rGc489ae2a8605761d784171ff7152dfc75ab7c064>. Please let me know if you are still having any problems.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83247/new/

https://reviews.llvm.org/D83247