[PATCH] D82698: [NewPM] make parsePassPipeline parse adaptor-wrapped user passes

[Yuanfang Chen via Phabricator via llvm-commits]

ychen marked an inline comment as done.
ychen added inline comments.


================
Comment at: llvm/test/Other/pass-pipeline-parsing.ll:182
+; CHECK-ADAPTORS: Running pass: ModuleToFunctionPassAdaptor<{{.*}}NoOpFunctionPass>
+; CHECK-ADAPTORS: Running pass: ModuleToFunctionPassAdaptor<{{.*}}FunctionToLoopPassAdaptor<{{.*}}NoOpLoopPass>{{.*}}>
+; CHECK-ADAPTORS: Running pass: ModuleToPostOrderCGSCCPassAdaptor<{{.*}}NoOpCGSCCPass>
----------------
aeubanks wrote:
> ychen wrote:
> > aeubanks wrote:
> > > what about a separate check for
> > > Running pass: FunctionToLoopPassAdaptor<{{.*}}NoOpLoopPass>
> > > and NoOpLoopPass itself?
> > I'm happy to do that. What is the motivation?
> To make sure that the FunctionToLoopPassAdaptor itself isn't skipped for some reason, and the same with the NoOpLoopPass.
Is line 191 what you refer to?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82698/new/

https://reviews.llvm.org/D82698