[PATCH] D67687: [NewPM][CodeGen] Introduce machine pass and machine pass manager

[Yuanfang Chen via Phabricator via llvm-commits]

ychen marked an inline comment as done.
ychen added a comment.

In D67687#2156911 <https://reviews.llvm.org/D67687#2156911>, @aeubanks wrote:

> Can you update the commit description to say what's going on?


updated.



================
Comment at: llvm/include/llvm/CodeGen/MachinePassManager.h:120
+    PassConceptT *P = Passes.back().get();
+    addDoInitialization<PassT>(P);
+    addDoFinalization<PassT>(P);
----------------
aeubanks wrote:
> Are we still doing the initialization/finalization thing?
I think we have to keep it until we're certain that the alternatives work well, especially for the use cases like AsmPrinter. But that requires we have at least a partially working pipeline with NPM. How about I add a FIXME? We could visit this later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67687/new/

https://reviews.llvm.org/D67687