[PATCH] D83204: [ARM] More unpredictable VCVT instructions.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMInstrVFP.td:1603
   let D = VFPNeonA8Domain;
+  let hasSideEffects = 0;
 }
----------------
Move this to AVConv1InsS_Encode?


================
Comment at: llvm/unittests/Target/ARM/MachineInstrTest.cpp:1106
     const MCInstrDesc &Desc = TII->get(Op);
-    if ((Desc.TSFlags & ARMII::DomainMask) != ARMII::DomainMVE &&
-        (Desc.TSFlags & ARMII::DomainMask) != ARMII::DomainVFP)
+    if (((Desc.TSFlags & ARMII::DomainMask) &
+         (ARMII::DomainMVE | ARMII::DomainVFP | ARMII::DomainNEONA8)) == 0)
----------------
Unnecessary parentheses around first "&".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83204/new/

https://reviews.llvm.org/D83204