[PATCH] D83866: [SystemZ/ZOS] Additions to the build system.

[David Tenty via Phabricator via llvm-commits]

daltenty added inline comments.


================
Comment at: llvm/cmake/modules/GetHostTriple.cmake:19
+    set( value "s390x-ibm-zos" )
   elseif( CMAKE_HOST_SYSTEM_NAME STREQUAL AIX )
     # We defer to dynamic detection of the host AIX version.
----------------
hubert.reinterpretcast wrote:
> I think `CMAKE_SYSTEM_NAME` (used above for z/OS) is right: The "host" of the resulting build is the target of this CMake build. @daltenty, if you agree, I think a small patch would make sense (likely to create a merge conflict with this one though)...
I agree that is probably more desirable in the long run, though it does create a behavior difference between platforms which rely on "config.guess" (which won't respect the CMAKE_SYSTEM_NAME and will always use the host) and those that don't (i.e. AIX / z/OS).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83866/new/

https://reviews.llvm.org/D83866