[PATCH] D83924: [mlir] Add update_mlir_test_checks.py

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer added a comment.

In D83924#2156773 <https://reviews.llvm.org/D83924#2156773>, @rriddle wrote:

> There seems to be a lot of hardcoding in here related to `func`. Given that `func` is not even the only function in upstream MLIR, and that for several dialects(existing and upcoming) `func` isn't even used at all, what is the story for those users?


I've been scratching my head a bit about how to build tools like this which need to understand the custom op formats.  I'm also thinking of things like automatic syntax highlighting in emacs/other editors.  One possibility is that this should actually be an MLIR-based tool which uses a different syntax which parses comments as ops. It would then be able to query operations and apply rules for where test boundaries should be.  so instead of 'func' hardcoded as a string, the tool would query for FunctionLikeInterface.  There are other things in here that are hardcoded too in regexps.  The best thing I can say at the moment is that the tool just won't work in such cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83924/new/

https://reviews.llvm.org/D83924