[PATCH] D83924: [mlir] Add update_mlir_test_checks.py

Stephen Neuendorffer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 16 12:28:05 PDT 2020


stephenneuendorffer added a comment.

In D83924#2156278 <https://reviews.llvm.org/D83924#2156278>, @silvas wrote:

> It's kind of confusing that this is in llvm/utils while generate-test-checks.py is in mlir/utils. Is there a plan to reconcile this difference?


it exists in llvm/utils because there are a bunch of other similar scripts there (for llc, mir, ll, etc.)  I'm open to suggestions on how to reconcile this.  Personally, I would replace generate-test-checks.py with this, because I think it's easier to use in most cases, but sometimes generate-test-checks.py might be better.   We could, perhaps, add an option to this that doesn't modify the test, but just generates the test checks on standard out which would enable both usage models.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83924/new/

https://reviews.llvm.org/D83924





More information about the llvm-commits mailing list