[PATCH] D82698: [NewPM] make parsePassPipeline parse adaptor-wrapped user passes

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 16 12:02:29 PDT 2020


ychen added a comment.

In D82698#2145079 <https://reviews.llvm.org/D82698#2145079>, @aeubanks wrote:

> Not sure exactly how to write a test for this, but it'd be nice to test a case where we have a module pass and a function pass both named the same. e.g. in PassRegistry.def there are multiple passes called "print".


Interesting. I would argue that passes with same name are extremely rare, probably just "print". For "print", it has a version for each pass type except CGSCC which means only CGSCC pipeline would possibly hit this adaptor code path. I've added a test case for this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82698/new/

https://reviews.llvm.org/D82698





More information about the llvm-commits mailing list