[PATCH] D82549: [AIX][XCOFF] parsing xcoff object file auxiliary header

Thu Jul 16 11:38:22 PDT 2020

jasonliu added inline comments.

================
Comment at: llvm/include/llvm/Object/XCOFFObjectFile.h:65

+static constexpr uint8_t AuxiHeaderFlagMask = 0xF0;
+static constexpr uint8_t AuxiHeaderTDataAlignmentMask = 0x0F;
----------------
This block currently cut in between XCOFFSectionHeader code block. 
I would suggest to move the new block to the current line 51. 
Also, is it worth to consider taking the XCOFFSectionHeader template approach now? Just like  XCOFFSectionHeader, we have same member functions and share the same mask between 32 and 64 bit.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82549/new/

https://reviews.llvm.org/D82549