[PATCH] D83736: [WebAssembly][NFC] Autogenerate tests for simd-select.ll

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 16 11:02:05 PDT 2020


tlively added a comment.

In D83736#2154884 <https://reviews.llvm.org/D83736#2154884>, @aheejin wrote:

> LGTM.
>  Nit: NFC <https://llvm.org/docs/Lexicon.html#n> usually means code change that does not affect output, so adding tests or changing tests is not NFC by that definition :)


Oof, I can never remember that for some reason :(


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83736/new/

https://reviews.llvm.org/D83736





More information about the llvm-commits mailing list