[PATCH] D81361: Make lit TestRunner.py work in Python 3
Tim Kientzle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 16 11:01:44 PDT 2020
tbkka added a comment.
Here are some more details:
Swift's lit.cfg wraps certain substitutions in a class that is part of LLVM's lit implementation (specifically `class SubstituteCaptures` from `TestingConfig.py`). This class breaks the logic in `TestRunner.py` on Python3: Python 2.7's regex always stringified its arguments implicitly; Python3 does not. Apparently, the `SubstituteCaptures` class is not currently used anywhere in LLVM itself, which is why this mismatch isn't breaking LLVM builds.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81361/new/
https://reviews.llvm.org/D81361
More information about the llvm-commits
mailing list