[PATCH] D83918: [llvm] Moved InlineSizeEstimatorAnalysis test to .ll

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 16 09:47:57 PDT 2020


mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.

Awesome! Thanks



================
Comment at: llvm/test/Transforms/Inline/ML/Inputs/size-estimator.ll:28
+  ret i32 %2
+}
----------------
I'm curious why you have the IR as a separate input file instead of having it inside the lit test? Is this because you wanted to not duplicate the IR in the two tests?
Merging the two tests with different check-prefix was reducing readability?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83918/new/

https://reviews.llvm.org/D83918





More information about the llvm-commits mailing list