[PATCH] D83949: [TSan] Do not compound reads and writes when separated by atomics
Marco Elver via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 16 09:07:34 PDT 2020
melver added a comment.
In D83949#2155877 <https://reviews.llvm.org/D83949#2155877>, @dvyukov wrote:
> > In practice, it probably doesn't really matter because T0 would probably load acquire spin on B or something better, and it'd be all in separate basic blocks.
>
> Yes, that's what I am thinking as well. This only makes difference for a ~1 instruction window for the context where everything is timing dependent anyway...
Should we drop this? I think unless Alex has objections, I think it's fine to drop. I certainly don't feel too strongly either way.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83949/new/
https://reviews.llvm.org/D83949
More information about the llvm-commits
mailing list