[PATCH] D83216: [Intrinsic] Add sshl.sat/ushl.sat, saturated shift intrinsics.

[Bevin Hansson via Phabricator via llvm-commits]

ebevhan marked 3 inline comments as done.
ebevhan added inline comments.


================
Comment at: llvm/docs/LangRef.rst:14459
 '``llvm.umul.fix.*``' Intrinsics
-^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
----------------
lebedev.ri wrote:
> arsenm wrote:
> > Unrelated changes
> Please just commit these changes to already-existing lines directly.
I factored out the other fixes into a separate commit.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:787
 
+SDValue DAGTypeLegalizer::PromoteIntRes_SHLSAT(SDNode *N) {
+  // Expand it to
----------------
lebedev.ri wrote:
> ebevhan wrote:
> > arsenm wrote:
> > > This code is exactly the same as for ADD/SUB sat and should be shared
> > The code is not exactly the same, but some of it is. I could try factoring it in. I find that code that does a lot is a bit harder to read, though.
> While i'm usually against duplication, i'm not not very sure that in this case it is better to deduplicate.
I deduplicated anyway. I don't think it ended up too bad.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83216/new/

https://reviews.llvm.org/D83216