[PATCH] D82576: [PowerPC][Power10] Implement low-order Vector Modulus Builtins, and add Vector Multiply/Divide/Modulus Builtins Tests

[Amy Kwan via Phabricator via llvm-commits]

amyk marked an inline comment as done.
amyk added inline comments.


================
Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:28
+  return vec_mul(vulla, vullb);
+}
+
----------------
bsaleil wrote:
> Are the tests for `vec_mul` with `v4i32` missing ?
I should probably reword the description. So for Power10, we actually have new instructions for:
- mul with v2i64
- div with v4i32 and v2i64
- mod with v4i32 and v2i64

Which is why I have only added `vec_mul` for `v4i32` here. All of those functions exist in altivec.h already except for `vec_mod`, which I have added.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82576/new/

https://reviews.llvm.org/D82576