[PATCH] D83778: MIPS: add build time option to disable madd.fmt

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 16 08:12:41 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/lib/Target/Mips/MipsSubtarget.cpp:265
+#if LLVM_DISABLE_MIPS_MADD4
+  DisableMadd4 = true;
+#endif
----------------
`+nomadd4` & `-nomadd4` below is fine. However, `DisableMadd4 = true;` is ok.
Can the disabling done in `lib/Driver` when the problematic CPUs are detected?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83778/new/

https://reviews.llvm.org/D83778





More information about the llvm-commits mailing list