[PATCH] D83945: [SystemZ/ZOS] Implement setLastAccessAndModificationTime()

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 16 06:08:34 PDT 2020


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Support/Unix/Path.inc:801
+  Attr.att_mtime = sys::toTimeT(ModificationTime);
+  if (::__fchattr(FD, &Attr, sizeof(Attr)))
+    return std::error_code(errno, std::generic_category());
----------------
Minor nit: As a function returning `int` (with `0` representing success), I would suggest using `!= 0` to check for the error condition.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83945/new/

https://reviews.llvm.org/D83945





More information about the llvm-commits mailing list