[PATCH] D67687: [CodeGen] Define an interface for the new pass manager. (new)

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/MachinePassManager.cpp:33
+  // TODO: implement RequireCodeGenSCCOrder
+  (void)RequireCodeGenSCCOrder;
+
----------------
assert(!RequireCodeGenSCCOrder && "not implemented")?


================
Comment at: llvm/lib/CodeGen/MachinePassManager.cpp:35
+
+  if (DebugLogging)
+    dbgs() << "Starting " << getTypeName<MachineFunction>()
----------------
Braces


================
Comment at: llvm/lib/CodeGen/MachinePassManager.cpp:53
+        return Err;
+      else
+        continue;
----------------
No else after return


================
Comment at: llvm/lib/CodeGen/MachinePassManager.cpp:68
+
+      if (DebugLogging)
+        dbgs() << "Running pass: " << P->name() << " on " << MF.getName()
----------------
Braces


================
Comment at: llvm/lib/CodeGen/MachinePassManager.cpp:70
+        dbgs() << "Running pass: " << P->name() << " on " << MF.getName()
+               << "\n";
+
----------------
Single quotes


================
Comment at: llvm/lib/CodeGen/MachinePassManager.cpp:79
+
+  for (auto &F : FinalizationFuncs)
+    if (auto Err = F(M, MFAM))
----------------
Braecs


================
Comment at: llvm/lib/CodeGen/MachinePassManager.cpp:83
+
+  if (DebugLogging)
+    dbgs() << "Finished " << getTypeName<MachineFunction>()
----------------
Braces


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67687/new/

https://reviews.llvm.org/D67687