[PATCH] D83216: [Intrinsic] Add sshl.sat/ushl.sat, saturated shift intrinsics.

Bevin Hansson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 16 04:36:12 PDT 2020


ebevhan added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:787
 
+SDValue DAGTypeLegalizer::PromoteIntRes_SHLSAT(SDNode *N) {
+  // Expand it to
----------------
arsenm wrote:
> This code is exactly the same as for ADD/SUB sat and should be shared
The code is not exactly the same, but some of it is. I could try factoring it in. I find that code that does a lot is a bit harder to read, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83216/new/

https://reviews.llvm.org/D83216





More information about the llvm-commits mailing list