[PATCH] D83867: [TSan] Add option for emitting compound read-write instrumentation

[Alexander Potapenko via Phabricator via llvm-commits]

glider added a comment.

What happens if the load and the store are separated by a barrier atomic load or store? Will they also be combined into a single operation?



================
Comment at: llvm/test/Instrumentation/ThreadSanitizer/read_before_write.ll:78
+; CHECK-COMPOUND-VOLATILE: __tsan_volatile_read
+; CHECK-COMPOUND: __tsan_read_write
+; CHECK-COMPOUND-VOLATILE: __tsan_volatile_write
----------------
Don't we want to treat pairs of volatile loads and stores as separate accesses? E.g. a volatile load may be racing with a completely different store somewhere else.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83867/new/

https://reviews.llvm.org/D83867