[PATCH] D83247: [compiler-rt][asan][hwasan] Refactor shadow setup into sanitizer_common (NFCI)

Thu Jul 16 03:10:10 PDT 2020

vitalybuka added a comment.

In D83247#2154772 <https://reviews.llvm.org/D83247#2154772>, @tejohnson wrote:

> In D83247#2154738 <https://reviews.llvm.org/D83247#2154738>, @vitalybuka wrote:
>
> > Thank you! LGTM
> >
> > Windows should work. For the rest we need to rely on bots.
>
>
> Great thanks - did you still want me to move the shadow functions to some new files (e.g. sanitizer_common/sanitizer_shadow_{linux_libcdep, win, mac}.cpp before committing?

maybe better to land and fix if anything broken, and maybe move later.  I guess I don't mind if we keep them as-is.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83247/new/

https://reviews.llvm.org/D83247