[PATCH] D83361: [LLVM] Add libatomic load/store functions to TargetLibraryInfo

Diana Picus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 16 01:37:56 PDT 2020


rovka added a comment.

Thanks for the update. This looks fine to me as is, but I'll defer the final LGTM to someone that knows this area a bit better.



================
Comment at: llvm/lib/Analysis/TargetLibraryInfo.cpp:178
 
+  bool isARM = (T.getArch() == Triple::aarch64 || T.getArch() == Triple::arm);
+
----------------
Nit: this doesn't need to move.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83361/new/

https://reviews.llvm.org/D83361





More information about the llvm-commits mailing list