[PATCH] D83801: [MC] Pass the section to onSymbolStart() for more context

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 16 01:01:57 PDT 2020


jhenderson added a comment.

Like @MaskRay, I'm going to see more usage of this to be able to properly comment on this change itself. However, one major point that needs highlighting is that this introduces a dependency on the Object library from the MC Disassembler, which doesn't currently exist. As far as I can tell, there are no references from MC or MCDisassembler to Object, but there are the other way around. That probably means this approach is a no-go. On the other hand, there is a `SectionKind.h` header file in MC, which might be an appropriate thing to use/extend if you need to identify the type of a section.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83801/new/

https://reviews.llvm.org/D83801





More information about the llvm-commits mailing list