[PATCH] D83704: [llvm-readobj] Print error when executed with no input files

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, once a couple of nits are fixed.

By the way, you can show that two commits have dependencies on each other by using the "Edit Related Revisions" Phabricator UI option, or by putting "Depends on DXXXXXX" in the description of the patch.



================
Comment at: llvm/test/tools/llvm-readobj/basic.test:7
 
+# Test case with no input file
+RUN: not llvm-readobj 2>&1 | FileCheck %s --check-prefix=NO-FILE
----------------
Nit: missing full stop.


================
Comment at: llvm/tools/llvm-readobj/llvm-readobj.cpp:695
+  if (opts::InputFilenames.empty()) {
+    error("No input files specified"); 
+  }
----------------
Use lower case for the first letter of error and warning messages (see https://llvm.org/docs/CodingStandards.html#error-and-warning-messages).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83704/new/

https://reviews.llvm.org/D83704