[PATCH] D83924: [mlir] Add update_mlir_test_checks.py
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 15 20:37:54 PDT 2020
mehdi_amini added inline comments.
================
Comment at: llvm/utils/update_mlir_test_checks.py:29
+The script is designed to make adding checks to a test case fast, it is *not*
+designed to be authoratitive about what constitutes a good test!
+"""
----------------
Something that I believe is important is to not just have blindly generated CHECKs but have a human editing the tests (documenting, minimizing the number of checks, etc.).
Can we have the script adding a paragraph mentioning in the actual generated test? (with a link to the testing guide, etc.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83924/new/
https://reviews.llvm.org/D83924
More information about the llvm-commits
mailing list