[PATCH] D83265: [MBP] Use profile count to compute tail dup cost if it is available

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 15 20:22:46 PDT 2020


davidxl added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineBlockPlacement.cpp:3167
+  SmallVector<MachineBasicBlock *, 8> Succs;
+  for (MachineBasicBlock *Succ : BB->successors()) {
+    if (BlockFilter && !BlockFilter->count(Succ))
----------------
Carrot wrote:
> davidxl wrote:
> > Is this change related?
> It is not profile count cost model related.
> It is a different tail dup improvement.
> Do you want me to send another patch for it?
Better separate it. Is the contributing to the performance improvement mentioned?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83265/new/

https://reviews.llvm.org/D83265





More information about the llvm-commits mailing list