[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 15 18:30:50 PDT 2020


echristo added a comment.

In D83360#2154637 <https://reviews.llvm.org/D83360#2154637>, @aqjune wrote:

> In D83360#2154584 <https://reviews.llvm.org/D83360#2154584>, @echristo wrote:
>
> > It's that even before the msan instrumentation the IR doesn't look correct - thus a miscompile.
>
>
> I'll share a prototype of the InstSimplify patch on Phabricator, in a day or two; it would be great if the miscompilation is fixed with the patch.


Would it be reasonable to revert this in the meantime?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83360/new/

https://reviews.llvm.org/D83360





More information about the llvm-commits mailing list