[PATCH] D83034: [GlobalISel] Don't skip adding predicate matcher

[Daniel Sanders via Phabricator via llvm-commits]

dsanders added inline comments.


================
Comment at: llvm/utils/TableGen/GlobalISelEmitter.cpp:3575
+      HasPredicateCode = true;
+      InsnMatcher.addPredicate<GenericInstructionPredicateMatcher>(Predicate);
+    }
----------------
dsanders wrote:
> madhur13490 wrote:
> > arsenm wrote:
> > > I think this should remain as the last predicate type added to the matcher, after everything else here. The ordering does matter (see D82331)
> > Well, then we have to remove all "continue" statements. Are we fine with it? I always thought that we'll use custom predicates for things which are *not* covered in other checks. I am fine with keeping it at the end, just looking for consequences. 
> I'd be inclined to factor the builtins out into a function instead so they can return and then you resume at the code to check+add for custom predicates
Also, just to confirm I agree it should be added after the builtins. Otherwise your C++ can't assume anything covered by the builtins.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83034/new/

https://reviews.llvm.org/D83034