[PATCH] D83252: [XCOFF] Enable symbol alias for AIX

[Xiangling Liao via Phabricator via llvm-commits]

Xiangling_L added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1837
+  for (const auto &Alias : M.aliases()) {
+    const GlobalObject *Base = Alias.getBaseObject();
+    if (!Base)
----------------
I am suggesting we add tests also for `alias to alias` and either one scenario of `alias to ConstantExpr`.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-alias.ll:86
+; ASM-NEXT:  L..C3:
+; ASM-NEXT:    .tc bar_f[TC],bar_f
----------------
jasonliu wrote:
> Xiangling_L wrote:
> > I am suggesting to also test the usage of hidden and protected alias.
> I think it's worth to test the function aliasing with one of the visibility attribute. i.e. hidden.
> I don't think it's necessary to test all the combinations, as for aliasing purpose, they all go through similar path there. Extensive testing of visibility is already handled in visibility patch.
Yeah, agree. That works as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83252/new/

https://reviews.llvm.org/D83252