[PATCH] D83625: [TSan] Optimize handling of racy address

Joachim Protze via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 15 14:25:11 PDT 2020


protze.joachim updated this revision to Diff 278308.
protze.joachim added a comment.

I reverted the commit, because all buildbots failed for these tests:

  TEST 'ThreadSanitizer-Unit :: rtl/./TsanRtlTest-x86_64-Test/ThreadSanitizer.RaceWithOffset' FAILED
  TEST 'ThreadSanitizer-Unit :: rtl/./TsanRtlTest-x86_64-Test/ThreadSanitizer.RaceWithOffset2' FAILED

As I understand the issue, the two tests trigger data race on different memory locations, but only the first is reported and all following are suppressed for the same stack.
I updated the tests, so that the PC of the "memory access" is in the stacktrace.
I have no idea why this did not fail before.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83625/new/

https://reviews.llvm.org/D83625

Files:
  compiler-rt/lib/tsan/rtl/tsan_rtl_report.cpp
  compiler-rt/lib/tsan/tests/rtl/tsan_test_util.h
  compiler-rt/lib/tsan/tests/rtl/tsan_test_util_posix.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83625.278308.patch
Type: text/x-patch
Size: 6537 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200715/3b11c488/attachment.bin>


More information about the llvm-commits mailing list