[PATCH] D83252: [XCOFF] Enable symbol alias for AIX

[Jason Liu via Phabricator via llvm-commits]

jasonliu marked an inline comment as done.
jasonliu added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1406
+  // those labels.
+  if (TM.getTargetTriple().isOSBinFormatXCOFF()) {
+    assert(!isa<GlobalIFunc>(GIS) && "IFunc is not supported on AIX.");
----------------
DiggerLin wrote:
> change  if (TM.getTargetTriple().isOSBinFormatXCOFF() )
> to 
> if (TM.getTargetTriple().isOSBinFormatXCOFF() & IsFunction)
> 
> and we do no not need 
> if (IsFunction) 
> later
I'm not sure how that would work because this if statement also intends to handle GlobalVariable. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83252/new/

https://reviews.llvm.org/D83252