[PATCH] D80358: [MLIR] Add RegionKindInterface

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer marked 8 inline comments as done.
stephenneuendorffer added a comment.

In D80358#2153978 <https://reviews.llvm.org/D80358#2153978>, @bondhugula wrote:

> Quick question: how do we know in printed IR if something is a graph region or an SSA one?


You don't.  Syntactically, there is no distinction for unregistered ops.  Unregistered ops are handled conservatively as graph regions, so they are allowed to violate SSA dominance.  Passes that require dominance-order traversal (i.e. CSE) won't operate on regions inside unregistered ops.



================
Comment at: mlir/docs/LangRef.md:30
+called *Operations*, and edges, called *Values*. Each Value is the
+result of exactly one Operation or Block Argument, and has a *Value
+Type* defined by the [type system](#type-system).
----------------
bondhugula wrote:
> a Block Argument?
I parse it as  'exactly one (Operation or Block Argument)', so I think it makes sense as is?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80358/new/

https://reviews.llvm.org/D80358