[PATCH] D83833: [GISel] Add new GISel combiners for G_SELECT

Wed Jul 15 10:53:33 PDT 2020

mkitzan updated this revision to Diff 278244.
mkitzan added a comment.

Looks like my local build wasn't building all the targets (sorry, fixed now). The AMDGPU test failed as a result of moving the existing `select_same_val` combiner out of the `identity_combines` group. The diff update moves `select_same_val` back to `identity_combines` group. The update does not address @arsenm's comment (waiting on feedback from @craig.topper).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83833/new/

https://reviews.llvm.org/D83833

Files:
  llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h
  llvm/include/llvm/Target/GlobalISel/Combine.td
  llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp
  llvm/test/CodeGen/AArch64/GlobalISel/combine-select.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83833.278244.patch
Type: text/x-patch
Size: 8524 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200715/dd482ad1/attachment.bin>