[PATCH] D83561: [ScheduleDAG] Move DBG_VALUEs after first term forward.

Wed Jul 15 10:42:12 PDT 2020

fhahn added a comment.

In D83561#2151128 <https://reviews.llvm.org/D83561#2151128>, @jmorse wrote:

> (Drive-by review) Thanks for the patch -- it  looks good, and generating legal machine code is definitely better than illegal,

Thanks, very much appreciated.

>> it seems like currently there is no way to insert a proper DBG_VALUEs for such registers anyways.
> 
> I agree with this -- IMHO, this patch should also make any moved DBG_VALUE an undef / $noreg DBG_VALUE. If the DBG_VALUE somehow refers to a register defined by the first terminator, then it'll definitely be wrong after being moved, and will be clobbered on the next instruction anyway. All other DBG_VALUEs can't have been attached to the terminator node, and will have been emitted before the first terminator (lines 986 of this patch to 996).

Sounds good to me. Is there an easy way to do so?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83561/new/

https://reviews.llvm.org/D83561