[PATCH] D83449: [llvm] Add contains(KeyType) -> bool methods to Set types.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 15 09:56:02 PDT 2020


fhahn added reviewers: dblaikie, fhahn.
fhahn added a comment.

Nice, IMO this makes a lot of sense and will help to get rid of a lot of more verbose `find(x) != end()` expressions.

For most ADT classes, there are unit tests in  llvm/unittests/ADT/. It would be good to add additional tests there. Also ,it would be good to add a proper doc-comment in all classes, as well as including the prior art comment in the description and replacing [llvm] with [ADT].


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83449/new/

https://reviews.llvm.org/D83449





More information about the llvm-commits mailing list